Skip to content

fix: add timeout for download from gcs#629

Merged
joein merged 1 commit intomainfrom
timeout-for-gcs
Apr 21, 2026
Merged

fix: add timeout for download from gcs#629
joein merged 1 commit intomainfrom
timeout-for-gcs

Conversation

@joein
Copy link
Copy Markdown
Member

@joein joein commented Apr 17, 2026

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49fef0b7-2d6f-4bd6-b78e-5914a9c20fd8

📥 Commits

Reviewing files that changed from the base of the PR and between 1ec283c and b825a2c.

📒 Files selected for processing (1)
  • fastembed/common/model_management.py
📝 Walkthrough

Walkthrough

The ModelManagement.download_file_from_gcs() method in fastembed/common/model_management.py has been modified to include a request timeout when calling requests.get(). The timeout is specified as a tuple (10, 120) representing connect and read timeouts in seconds. All other functionality, including early returns, error handling, and streaming behavior, remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a timeout parameter to the GCS download function.
Description check ✅ Passed The description references issue #627, which provides context for the change, though it is minimal.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch timeout-for-gcs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joein joein requested a review from tbung April 17, 2026 13:51
@joein joein merged commit adfc1ae into main Apr 21, 2026
13 checks passed
@joein joein deleted the timeout-for-gcs branch April 21, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbung tbung tbung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joein @tbung